Главная задача контроллера, по сути, только разрулить HTTP-часть.
Плохой пример: бизнес-правила запихнуты в контроллер, типа проверки остатков и лимита заказа:
@RestController
@RequestMapping("/api/orders")
public class OrderController {
@Autowired
private OrderRepository orderRepository;
@Autowired
private ProductRepository productRepository;
@PostMapping
public ResponseEntity<?> createOrder(@RequestBody CreateOrderRequest request) {
// Validation logic
if (request.getProductId() == null || request.getQuantity() <= 0) {
return ResponseEntity
.badRequest()
.body("Invalid request");
}
// Business logic
Product product = productRepository.findById(request.getProductId())
.orElse(null);
if (product == null) {
return ResponseEntity
.status(HttpStatus.NOT_FOUND)
.body("Product not found");
}
if (product.getStock() < request.getQuantity()) {
return ResponseEntity
.badRequest()
.body("Not enough stock");
}
BigDecimal totalPrice = product.getPrice()
.multiply(BigDecimal.valueOf(request.getQuantity()));
if (totalPrice.compareTo(new BigDecimal("10000")) > 0) {
return ResponseEntity
.badRequest()
.body("Order limit exceeded");
}
// Persistence + transaction logic
product.setStock(product.getStock() - request.getQuantity());
productRepository.save(product);
Order order = new Order();
order.setProduct(product);
order.setQuantity(request.getQuantity());
order.setTotalPrice(totalPrice);
order.setCreatedAt(LocalDateTime.now());
orderRepository.save(order);
return ResponseEntity
.status(HttpStatus.CREATED)
.body(order.getId());
}
}
👉 Java Portal
